Create a v2 snapshot when running etcdutl migrate command #19168
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ahrtr
force-pushed
the
etcdutl_snapshot_20250110
branch
2 times, most recently
from
250f708 to
d8f3b56
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
... and 20 files with indirect coverage changes @@ Coverage Diff @@
## main #19168 +/- ##
==========================================
- Coverage 68.87% 68.77% -0.11%
==========================================
Files 420 421 +1
Lines 35649 35736 +87
==========================================
+ Hits 24554 24576 +22
- Misses 9674 9741 +67
+ Partials 1421 1419 -2 Continue to review full report in Codecov by Sentry.
|
Signed-off-by: Benjamin Wang <[email protected]>
ahrtr
force-pushed
the
etcdutl_snapshot_20250110
branch
from
d8f3b56 to
033f4cf
Compare
Refer to #17911 (comment)
This PR will make the
etcdutl migratecommand fully functional.It creates a v2snapshot from the v3store.
You will never see error below anymore when executing
etcdutl migratecommand,After executing the migrate command for all members, you just need to directly replace the binary of each member, then all done for the offline downgrade. Of course, it's still recommended to follow/perform the online downgrade process, as it doesn't break the workload. cc @ivanvc @jmhbnz
It also adds a separate
etcdutl v2snapshot createcommandIt's just a manual last to resort solution for any potential issue. Usually we don't need it.
I need to add e2e test. I may also break down it into smaller PRs.